Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #40

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Upgrade dependencies #40

wants to merge 9 commits into from

Conversation

NinaDen
Copy link

@NinaDen NinaDen commented Jul 8, 2022 •
edited
Loading

Changes:

  • Upgrade version of react-scripts
  • Fix webpack config according to changed in react-scripts 5
  • Add test of dreact on node 16
  • Resolve dependency tree errors

TODO:

  • Fix linter error on node 16 in cli/environment/webpack.config.js, line 47. Linter for node 12 and 14 and linter on node 16 ask for the opposite things:
  • node 12 and 14:
config.module.rules[1].oneOf[3].options.cacheIdentifier += getCacheIdentifier()
  • node 16:
config.module.rules[1].oneOf[3].options.cacheIdentifier +=
    getCacheIdentifier()

@NinaDen NinaDen added the WIP label Jul 8, 2022
@NinaDen NinaDen requested review from ezhlobo and atatarenko July 8, 2022 12:05
@NinaDen NinaDen force-pushed the upgrade-dependencies branch 2 times, most recently from 31fe7e8 to 1154a59 Compare July 13, 2022 08:00
@NinaDen NinaDen force-pushed the upgrade-dependencies branch from 57f3357 to da7ebf3 Compare July 21, 2022 10:03
@atatarenko
Copy link
Member

Hey @NinaDen – I see you get the thing from to-do list done but this PR still stays WIP. Can you confirm it's still WIP or it's ready for review?

@NinaDen
Copy link
Author

NinaDen commented Aug 2, 2022

Hey @NinaDen – I see you get the thing from to-do list done but this PR still stays WIP. Can you confirm it's still WIP or it's ready for review?

It's almost finished, I want to change eslint-config-datarockets version to new one and eslint version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezhlobo ezhlobo Awaiting requested review from ezhlobo

@atatarenko atatarenko Awaiting requested review from atatarenko

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NinaDen @atatarenko